Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting: editor.unicodeHighlight.ambiguousCharacters #2527

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

winjo
Copy link
Contributor

@winjo winjo commented Mar 30, 2023

Types

  • ๐ŸŽ‰ New Features
  • ๐Ÿ› Bug Fixes
  • ๐Ÿ“š Documentation Changes
  • ๐Ÿ’„ Code Style Changes
  • ๐Ÿ’„ Style Changes
  • ๐Ÿชš Refactors
  • ๐Ÿš€ Performance Improvements
  • ๐Ÿ—๏ธ Build System
  • โฑ Tests
  • ๐Ÿงน Chores
  • Other Changes

Background or solution

close: #2303

Changelog

ๆ”ฏๆŒ editor.unicodeHighlight.ambiguousCharacters ้…็ฝฎ๏ผŒ้ป˜่ฎคๅผ€ๅฏ
ๆˆชๅฑ2023-03-30 15 55 39

@winjo winjo requested a review from Ricbet March 30, 2023 08:00
@github-actions github-actions bot added the ๐ŸŽจ feature feature required label Mar 30, 2023
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 โš ๏ธ

Comparison is base (f2db574) 57.71% compared to head (cfb67a2) 57.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   57.71%   57.71%   -0.01%     
==========================================
  Files        1322     1322              
  Lines       83447    83447              
  Branches    17361    17361              
==========================================
- Hits        48165    48164       -1     
- Misses      32059    32060       +1     
  Partials     3223     3223              
Flag Coverage ฮ”
jsdom 52.73% <รธ> (รธ)
node 16.75% <รธ> (-0.01%) โฌ‡๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
...ackages/editor/src/browser/preference/converter.ts 90.41% <รธ> (รธ)
packages/editor/src/browser/preference/schema.ts 100.00% <รธ> (รธ)
packages/i18n/src/common/en-US.lang.ts 100.00% <รธ> (รธ)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <รธ> (รธ)
...erences/src/browser/preference-settings.service.ts 72.19% <รธ> (รธ)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Do you have feedback about the report comment? Let us know in this issue.

@winjo winjo merged commit 8446313 into main Mar 30, 2023
@winjo winjo deleted the feat/settings-editor-unicodeHighlight branch March 30, 2023 08:45
@erha19 erha19 added this to the 2.24 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŽจ feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] ๅฎž็Žฐ editor.unicodeHighlight.ambiguousCharacters ้…็ฝฎ้กน
3 participants