Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ai-native): optimize monaco contrib registration #3763

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

  • 🪚 Refactors

Background or solution

修复内联补全偶现不出现(快速敲击时必现不出现)

重构了注册 monaco 相关能力的逻辑

Changelog

Fix inline completion occasionally not appearing
optimize monaco contrib registration

@bytemain bytemain requested a review from Ricbet June 11, 2024 12:15
Copy link

railway-app bot commented Jun 11, 2024

🚅 Previously deployed to Railway in the core project. Environment has been deleted.

@opensumi opensumi bot added the ⚙️ refactor Refactor code label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 3.61446% with 160 lines in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (8f27e53) to head (7aa9736).

Files Patch % Lines
...browser/contrib/code-action/code-action.handler.ts 0.00% 41 Missing and 10 partials ⚠️
...ser/contrib/inline-completions/completeProvider.ts 0.00% 41 Missing and 3 partials ⚠️
...b/inline-completions/inline-completions.handler.ts 0.00% 24 Missing and 5 partials ⚠️
...ckages/ai-native/src/browser/contrib/base/index.ts 0.00% 19 Missing and 1 partial ⚠️
...ative/src/browser/contrib/rename/rename.handler.ts 0.00% 8 Missing and 1 partial ⚠️
...ackages/ai-native/src/browser/preferences/index.ts 0.00% 4 Missing ⚠️
...ckages/ai-native/src/browser/preferences/schema.ts 0.00% 2 Missing ⚠️
packages/ai-native/src/browser/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3763       +/-   ##
===========================================
+ Coverage   15.57%   55.32%   +39.75%     
===========================================
  Files        1537     1540        +3     
  Lines       93871    93915       +44     
  Branches    19283    19282        -1     
===========================================
+ Hits        14618    51959    +37341     
+ Misses      66533    34812    -31721     
+ Partials    12720     7144     -5576     
Flag Coverage Δ
jsdom 50.78% <3.61%> (?)
node 15.56% <3.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 30f81b6 into main Jun 12, 2024
12 checks passed
@bytemain bytemain deleted the refactor/optimize-ai-native-contrib branch June 12, 2024 02:39
@Ricbet
Copy link
Member

Ricbet commented Jun 12, 2024

backport v3.1

@Ricbet
Copy link
Member

Ricbet commented Jun 12, 2024

/backport v3.1

@opensumi
Copy link
Contributor

opensumi bot commented Jun 12, 2024

Cannot extract the target branch from /backport v3.1

Example: backport to v2.23

@Ricbet
Copy link
Member

Ricbet commented Jun 12, 2024

/backport to v3.1

@opensumi
Copy link
Contributor

opensumi bot commented Jun 12, 2024

Cannot extract the target branch from /backport to v3.1

Example: backport to v2.23

@bytemain
Copy link
Member Author

/backport to v3.1

@opensumi
Copy link
Contributor

opensumi bot commented Jun 12, 2024

Backporting to v3.1 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants