-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set _currentScope when update tabList in constructor #3979
Conversation
This PR was not deployed automatically as @winjo does not have access to the Railway project. In order to get automatic PR deploys, please add @winjo to the project inside the project settings page. |
Walkthrough此次更改涉及到 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PreferenceSettingsService
User->>PreferenceSettingsService: 更新工作区设置
PreferenceSettingsService-->>User: 确认设置已更新
alt userBeforeWorkspace 为真
PreferenceSettingsService->>PreferenceSettingsService: 设置 this._currentScope = this.tabList[this.tabIndex]
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
- Coverage 54.87% 54.86% -0.01%
==========================================
Files 1568 1568
Lines 95652 95653 +1
Branches 19605 19605
==========================================
- Hits 52490 52482 -8
- Misses 35841 35848 +7
- Partials 7321 7323 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
settings.userBeforeWorkspace 设置为 true 时,此时在 constructor 会更新 tabList,但未更新 currentScope,导致 ui 上 tab 渲染的是 user preference,但实际操作的是 workspace preference
Changelog
修复 userBeforeWorkspace setting 配置设置异常的问题
Summary by CodeRabbit