-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on some very intense queries. I have a few suggestions for updates and would like to walk through percent_facilities_with_multiple_matches.sql
on a Meet with you.
src/django/api/reports/percent_facilities_with_multiple_matches.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the updates ran the reports on production, and put the report results in a document. The results match my expectations.
Thank you for pairing with me to work through these queries together. I learned a new technique in the process.
@@ -0,0 +1,18 @@ | |||
SELECT | |||
fm.month, | |||
(COUNT(CASE WHEN fm.is_public_list THEN 1 ELSE NULL END)*100)/COUNT(*) AS oar_data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that these two columns are not adding up to 100 when we do integer division. I think we should apply the same CAST and ROUND approach that we have used on our other percentage reports here.
b3759f0
to
5a4920c
Compare
Overview
With the new round of funding from Laudes Foundation, the KPIs we are tracking and reporting on have changed. There is a new set of monthly reports needed.
Connects #1306
Demo
Testing Instructions
./scripts/server
and login as an adminChecklist
fixup!
commits have been squashed