Raise 400 error for invalid contributor param type

CHANGELOG.md

@@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Fixed
 
+- Return 400/Bad Request error for /api/facilities request with invalid contributor parameter type. [#433](https://github.com/open-apparel-registry/open-apparel-registry/pull/433)
+
 ### Security
 
 ## [2.0.0] - 2019-03-27

src/django/api/serializers.py

@@ -6,9 +6,11 @@
 from django.urls import reverse
 from rest_framework.serializers import (CharField,
                                         EmailField,
+                                        IntegerField,
                                         ModelSerializer,
                                         SerializerMethodField,
-                                        ValidationError)
+                                        ValidationError,
+                                        Serializer)
 from rest_framework_gis.serializers import GeoFeatureModelSerializer
 from rest_auth.serializers import (PasswordResetSerializer,
                                    PasswordResetConfirmSerializer)
@@ -178,6 +180,15 @@ def get_statuses(self, facility_list):
                 .distinct())
 
 
+class FacilityQueryParamsSerializer(Serializer):
+    name = CharField(required=False)
+    contributors = IntegerField(required=False)
+    contributor_types = CharField(required=False)
+    countries = CharField(required=False)
+    page = IntegerField(required=False)
+    pageSize = IntegerField(required=False)
+
+
 class FacilitySerializer(GeoFeatureModelSerializer):
     oar_id = SerializerMethodField()
     country_name = SerializerMethodField()

src/django/api/views.py

@@ -38,6 +38,7 @@
 from api.processing import parse_csv_line
 from api.serializers import (FacilityListSerializer,
                              FacilityListItemSerializer,
+                             FacilityQueryParamsSerializer,
                              FacilitySerializer,
                              FacilityDetailsSerializer,
                              UserSerializer,
@@ -404,10 +405,16 @@ def list(self, request):
                 ]
             }
         """
+        params = FacilityQueryParamsSerializer(data=request.query_params)
+
+        if not params.is_valid():
+            raise ValidationError(params.errors)
+
         name = request.query_params.get(FacilitiesQueryParams.NAME,
                                         None)
         contributors = request.query_params \
                               .getlist(FacilitiesQueryParams.CONTRIBUTORS)
+
         contributor_types = request \
             .query_params \
             .getlist(FacilitiesQueryParams.CONTRIBUTOR_TYPES)