Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Homepage crash sharing parameter by value #298

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

chinmehta
Copy link
Contributor

@chinmehta chinmehta commented Nov 22, 2023

[Platform]: Homepage crash sharing parameter by value

sharing parameter by value instead of sharing it by reference.

Issue: # (link)
Deploy preview: (link)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A: navigate to home page multiple time by clicking on nav bar logo.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chinmehta chinmehta changed the title [Platform]: sharing parameter by value [Platform]: Homepage crash sharing parameter by value Nov 22, 2023
const classes = useStyles();
const suggestions = getSuggestedSearch();
// const suggestions = getSuggestedSearch();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

@carcruz carcruz merged commit 2755c1c into main Nov 23, 2023
11 checks passed
@carcruz carcruz deleted the cm-hompeage-crash branch November 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants