Vulnerability SQL tests #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pflynn-virtru
commented
Jan 21, 2022
•
pflynn-virtru
commented
- adds SQL injection tests
Comment on lines
+23
to
+37
| let genericSqlInjectionPayload: [string]; | ||
|
|
||
|
|
||
| test.beforeAll(async ({playwright}) => { | ||
| // read test data | ||
| const rl = readline.createInterface({ | ||
| input: fs.createReadStream('resources/generic-sql-injection-payload.txt'), | ||
| output: process.stdout, | ||
| terminal: false | ||
| }); | ||
| rl.on('line', (line) => { | ||
| if (line.trim()) { | ||
| if (!genericSqlInjectionPayload) { | ||
| genericSqlInjectionPayload = [line.trim()]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let genericSqlInjectionPayload: [string]; | |
| test.beforeAll(async ({playwright}) => { | |
| // read test data | |
| const rl = readline.createInterface({ | |
| input: fs.createReadStream('resources/generic-sql-injection-payload.txt'), | |
| output: process.stdout, | |
| terminal: false | |
| }); | |
| rl.on('line', (line) => { | |
| if (line.trim()) { | |
| if (!genericSqlInjectionPayload) { | |
| genericSqlInjectionPayload = [line.trim()]; | |
| } | |
| let genericSqlInjectionPayload = []: [string]; | |
| test.beforeAll(async ({playwright}) => { | |
| // read test data | |
| const rl = readline.createInterface({ | |
| input: fs.createReadStream('resources/generic-sql-injection-payload.txt'), | |
| output: process.stdout, | |
| terminal: false | |
| }); | |
| rl.on('line', (line) => { | |
| if (line.trim()) { |
There was a problem hiding this comment.
Suggestion: ^ Initialize as an empty array. This also avoids your repeat-initial-line bug in the current code
Comment on lines
+23
to
+37
| let genericSqlInjectionPayload: [string]; | ||
|
|
||
|
|
||
| test.beforeAll(async ({playwright}) => { | ||
| // read test data | ||
| const rl = readline.createInterface({ | ||
| input: fs.createReadStream('resources/generic-sql-injection-payload.txt'), | ||
| output: process.stdout, | ||
| terminal: false | ||
| }); | ||
| rl.on('line', (line) => { | ||
| if (line.trim()) { | ||
| if (!genericSqlInjectionPayload) { | ||
| genericSqlInjectionPayload = [line.trim()]; | ||
| } |
There was a problem hiding this comment.
Suggestion: ^ Initialize as an empty array. This also avoids your repeat-initial-line bug in the current code
| }); | ||
| expect(response.status()).not.toBe(constants.HTTP_STATUS_INTERNAL_SERVER_ERROR); | ||
| console.log(response.status()); | ||
| console.log((await response.body()).toString()); |
There was a problem hiding this comment.
Should we add some expectations here and below in similar code? Ideally tests wouldn't require a manual review which these seem to...
ivanovSPvirtru
pushed a commit
that referenced
this pull request
Feb 17, 2022
dmihalcik-virtru
added a commit
that referenced
this pull request
Mar 16, 2022
krokhmaliuk-virtru
pushed a commit
that referenced
this pull request
Apr 24, 2024
krokhmaliuk-virtru
pushed a commit
that referenced
this pull request
Apr 24, 2024
|
closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.