-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDSv3: Error "missing input for argument [KeepDays]" when keep_days is 0 #2262
Comments
RDS: Fix `keep_days` zero values Summary of the Pull Request Fix resource break when keep_days is set to 0. PR Checklist Refers to: #2262 Tests passed. Release notes added. Acceptance Steps Performed === RUN TestAccRdsPostgre13V3ParamsBasic --- PASS: TestAccRdsPostgre13V3ParamsBasic (457.13s) === RUN TestAccRdsInstanceV3Basic --- PASS: TestAccRdsInstanceV3Basic (836.01s) PASS Process finished with the exit code 0 Reviewed-by: Aloento
Hello @kaibernhard please check latest. |
Hello @artem-lifshits, thank you very much for your help. I don't see the error message any longer with 1.35.6, but it doesn't seem to apply the change to |
…2286) [RDS]: fix `keep_days` update for `opentelekomcloud_rds_instance_v3` Summary of the Pull Request Fix keep_days update when changing from 1 to 0 value. PR Checklist Refers to: #2262 Tests passed. Release notes added. Acceptance Steps Performed === RUN TestAccRdsInstanceV3Basic --- PASS: TestAccRdsInstanceV3Basic (762.16s) === RUN TestAccRdsPostgre13V3ParamsBasic --- PASS: TestAccRdsPostgre13V3ParamsBasic (533.63s) === RUN TestAccRdsInstanceV3ElasticIP --- PASS: TestAccRdsInstanceV3ElasticIP (761.48s) === RUN TestAccRdsInstanceV3OptionalParams --- PASS: TestAccRdsInstanceV3OptionalParams (394.23s) === RUN TestAccRdsInstanceV3Backup --- PASS: TestAccRdsInstanceV3Backup (359.66s) PASS Process finished with exit code 0 Reviewed-by: Vladimir Vshivkov Reviewed-by: Anton Sidelnikov Reviewed-by: Aloento
@kaibernhard please check the latest release. |
Fix confirmed, thank you @artem-lifshits! |
Terraform provider version
1.35.5
Affected Resource(s)
Terraform Configuration Files
The issue can be reproduced with the example Create a single db instance.
Steps to Reproduce
availability_zone
,subnet_id
,vpc_id
)keep_days = 1
tokeep_days = 0
terraform apply
and note that the error only occurs after confirmingyes
, not before, and not when runningterraform plan
.Expected Behavior
terraform apply
succeeds without errors, since the documentation for keep_days claims the value range is from 0 to 732 andterraform plan
succeeds.Actual Behavior
terraform apply
fails:The text was updated successfully, but these errors were encountered: