Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo fmt + require cargo fmt to pass in CI #253

Merged
merged 8 commits into from
Mar 13, 2024
Merged

cargo fmt + require cargo fmt to pass in CI #253

merged 8 commits into from
Mar 13, 2024

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Mar 12, 2024

  • fixes a bunch of trailing whitespace errors so cargo fmt can run
  • runs cargo fmt (apparently for the first time ever 😆)
  • requires cargo fmt --check to pass in CI from now on
  • now runs cargo test --workspace instead of just cargo test --tests which would only run integration tests
  • requires cargo check --workspace to pass in CI from now on (this will ensure non-test build succeeds without any errors) removed because CI was running out of disk space 🤣

update: going to keep cargo check --workspace out for now because it just adds to build time and we don't have parallel actions set up for the different steps, will do that in a later pr 👍🏻

@shibshib shibshib merged commit e607d7e into main Mar 13, 2024
1 check passed
@sam0x17 sam0x17 mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants