cargo fmt + require cargo fmt to pass in CI #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmt
can runcargo fmt
(apparently for the first time ever 😆)cargo fmt --check
to pass in CI from now oncargo test --workspace
instead of justcargo test --tests
which would only run integration testsrequiresremoved because CI was running out of disk space 🤣cargo check --workspace
to pass in CI from now on (this will ensure non-test build succeeds without any errors)update: going to keep
cargo check --workspace
out for now because it just adds to build time and we don't have parallel actions set up for the different steps, will do that in a later pr 👍🏻