[controller] allows polymorphism of the controller #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
controller_polymorphism
branch
from
7873437
to
f2fbf6a
Compare
Irving-cl
force-pushed
the
controller_polymorphism
branch
from
f2fbf6a
to
65f9ed9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
===========================================
- Coverage 55.77% 39.91% -15.87%
===========================================
Files 87 91 +4
Lines 6890 9897 +3007
Branches 0 732 +732
===========================================
+ Hits 3843 3950 +107
- Misses 3047 5745 +2698
- Partials 0 202 +202 ☔ View full report in Codecov by Sentry. |
Irving-cl
force-pushed
the
controller_polymorphism
branch
2 times, most recently
from
2b267de
to
9a9d979
Compare
superwhd
reviewed
Jun 3, 2024
Irving-cl
force-pushed
the
controller_polymorphism
branch
4 times, most recently
from
544c54d
to
6e6a9e7
Compare
superwhd
reviewed
Jun 4, 2024
| @@ -194,9 +188,19 @@ class RcpHost : public MainloopProcessor, public ThreadController | |||
|
|
|||
| ~RcpHost(void) override; | |||
|
|
|||
| // Thread Control APIs | |||
| // Thread Control virtual methods | |||
| void GetDeviceRole(const DeviceRoleHandler aHandler) override; | |||
There was a problem hiding this comment.
Maybe in a future PR: make this parameter either a non-const value or a const reference.
There was a problem hiding this comment.
SG. Let's do it in a seperate PR.
Irving-cl
force-pushed
the
controller_polymorphism
branch
3 times, most recently
from
e7f80e8
to
0eba402
Compare
Irving-cl
force-pushed
the
controller_polymorphism
branch
5 times, most recently
from
302de00
to
d083088
Compare
Irving-cl
force-pushed
the
controller_polymorphism
branch
from
d083088
to
e112593
Compare
Irving-cl
force-pushed
the
controller_polymorphism
branch
from
e112593
to
d5f616a
Compare
jwhui
reviewed
Jun 12, 2024
Irving-cl
force-pushed
the
controller_polymorphism
branch
from
d5f616a
to
fac7dd6
Compare
jwhui
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also a breakdown of #2283
This PR adds a factory method
CreateInstanceto provide polymorphismfor the
ThreadController. This PR moves the construction and initializationof the components to RCP specific methods and only contructs these
modules when the Co-processor is an RCP.