Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some npcs bugs and change behaviour #396

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented May 28, 2022

This works with: #396

Fixed:

  • Total cost for custom currencys
  • Bank npcs depot, transfer and withdraw logic

Changed:

  • MsgContains behaviour, added new function "MsgFind" so that we avoid some bugs in messages that have the same words
  • Added debug log for assistant with debug build

Copy link
Contributor

@guispiller guispiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in order to some functions work in bank system, they need to have be changed.
How it should work:
Deposit:
unknown
Transfer:
unknown

@majestyotbr majestyotbr marked this pull request as draft June 25, 2022 19:00
@dudantas dudantas marked this pull request as ready for review June 30, 2022 03:43
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 5b25b43 into main Jun 30, 2022
@dudantas dudantas deleted the fix-some-npcs-behaviour branch June 30, 2022 04:53
luan pushed a commit that referenced this pull request Jul 11, 2023
Fixed:
Total cost for custom currencys
Bank npcs depot, transfer and withdraw logic

Changed:
MsgContains behaviour, added new function "MsgFind" so that we avoid some bugs in messages that have the same words
Added debug log for assistant with debug build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants