Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show attributes look on de equip item #450

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Jul 23, 2022

Extracted the code in a separate function, so we can use it as an if/else condition and perform two different behaviors, one for an item that doesn't transform and another for an item that transforms

@dudantas dudantas added the Type: Enhancement New feature or request label Jul 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit f1613f4 into main Jul 23, 2022
@dudantas dudantas deleted the fix-show-attributes-de-equip-item branch July 23, 2022 18:20
luan pushed a commit that referenced this pull request Jul 11, 2023
Extracted the code in a separate function, so we can use it as an if/else condition and perform two different behaviors, one for an item that doesn't transform and another for an item that transforms

Co-author: @omeranha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Source Type: Enhancement New feature or request
Projects
Status: PRs Done
Development

Successfully merging this pull request may close these issues.

4 participants