Fixed clone depot items #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrossi
reviewed
Jul 26, 2022
Co-authored-by: Lucas Grossi <34237492+lgrossi@users.noreply.github.com>
guispiller
approved these changes
Jul 26, 2022
|
Kudos, SonarCloud Quality Gate passed! |
guispiller
approved these changes
Jul 27, 2022
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Resolves #449 With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #449
Fixes "cloning" bug of items through depot
With the wrong size, instead of getting all possible pages, it was stopping at the eighth page, which is the maximum number of items in uint8_t, so when there were more items it allowed to clone in a specific scenario, I will avoid giving examples so that they do not abuse the bug on the server of those who are not using the fix yet
Thanks @CzajaTwitch for reporting bug