Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

fix error handling; unexport func #100

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix error handling; unexport func #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/internal/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func FindRelease(ctx context.Context, ghClient *githubv4.Client, namespace, name
slog.Info("Finding release")

for {
nodes, endCursor, fetchErr := FetchReleaseNodes(tracedCtx, ghClient, variables)
nodes, endCursor, fetchErr := fetchReleaseNodes(tracedCtx, ghClient, variables)
if fetchErr != nil {
slog.Error("Failed to fetch release nodes", "error", fetchErr)
return fmt.Errorf("failed to fetch release nodes: %w", fetchErr)
Expand Down Expand Up @@ -135,7 +135,7 @@ func FetchReleases(ctx context.Context, ghClient *githubv4.Client, namespace, na
slog.Info("Fetching releases")

for {
nodes, endCursor, fetchErr := FetchReleaseNodes(tracedCtx, ghClient, variables)
nodes, endCursor, fetchErr := fetchReleaseNodes(tracedCtx, ghClient, variables)
if fetchErr != nil {
slog.Error("Failed to fetch release nodes", "error", fetchErr)
return fmt.Errorf("failed to fetch release nodes: %w", fetchErr)
Expand Down Expand Up @@ -174,13 +174,13 @@ func initVariables(namespace, name string) map[string]interface{} {
}
}

// FetchReleaseNodes will fetch a page of releases from the github api and return the nodes, endCursor, and an error
// fetchReleaseNodes will fetch a page of releases from the github api and return the nodes, endCursor, and an error
// endCursor will be nil if there are no more pages
func FetchReleaseNodes(ctx context.Context, ghClient *githubv4.Client, variables map[string]interface{}) (releases []GHRelease, endCursor *string, err error) {
func fetchReleaseNodes(ctx context.Context, ghClient *githubv4.Client, variables map[string]interface{}) (releases []GHRelease, endCursor *string, err error) {
err = xray.Capture(ctx, "github.releases.nodes", func(tracedCtx context.Context) error {
var query GHRepository

if queryErr := ghClient.Query(tracedCtx, &query, variables); err != nil {
if queryErr := ghClient.Query(tracedCtx, &query, variables); queryErr != nil {
return fmt.Errorf("failed to query for releases: %w", queryErr)
}

Expand Down
Loading