Tracing wrapper implementation causes Jedis resource being destroyed when returning to pool. #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Tracing wrapper implementation causes Jedis resource being destroyed when returning to pool.
When Jedis resource is destroyed socket associated with its client gets closed.
So, whenever you get instance from JedisPool, you get it in disconnected state - it is reconnecting any time you execute some action on it.
Consider test case scenario available in this PR:
Expected behavior
Jedis resource returned to pool should keep connection open for at least
BaseGenericObjectPool#getMinEvictableIdleTimeMillis
(by default 60 seconds)Changes introduced
TracingJedisWrapper
extendsJedis
resource & decorates all its methods with tracing spansTracingJedis
extendsTracingJedisWrapper
- so its public interface does not change