Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set scope=provided #45

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Set scope=provided #45

merged 1 commit into from
Sep 27, 2019

Conversation

safris
Copy link
Contributor

@safris safris commented Sep 25, 2019

Setting the scope of the target libraries of instrumentation to "provided". It is a guarantee that the integrating codebase will provide these libraries, otherwise the instrumentation plugin would be moot if the codebase does not already have these libraries.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 4.194%

Totals Coverage Status
Change from base Build 205: 4.2%
Covered Lines: 1086
Relevant Lines: 25897

💛 - Coveralls

@malafeev malafeev merged commit ceaf626 into opentracing-contrib:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants