Enable an existing WebTracingConfiguration to be used to initialise a… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new builder, used to update/replace the previous values
objectiser
force-pushed
the
webtracingcopy
branch
from
33dd6e0
to
d3a58cf
Compare
pavolloffay
reviewed
Aug 14, 2017
|
Updated to use the toBuilder approach. |
pavolloffay
reviewed
Aug 14, 2017
| public static class Builder { | ||
| private Pattern skipPattern; | ||
|
|
||
| public Builder() { |
There was a problem hiding this comment.
Maybe it's better to restrict to static Config.builder() only
pavolloffay
reviewed
Aug 14, 2017
| @@ -22,9 +22,20 @@ public static Builder builder() { | |||
| return new Builder(); | |||
| } | |||
|
|
|||
| public Builder toBuilder() { | |||
There was a problem hiding this comment.
We should also document that this is safe to use only with bean post processing (or maybe some similar approaches) because config values are propagated to different parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… new builder, used to update/replace the previous values
The BeanPostProcessor approach discussed in #28 works, but there is currently no way to update the skip pattern in the
WebTracingConfiguration. This PR provides ausingmethod on the builder to enable an existing configuration to be used to initialise the config before the other builder methods are used to change the values.Its not an issue currently, as the
WebTracingConfigurationonly has one property - but in the future it might cause issues if (for example) the metrics lib just returns a new config with the pattern but any other properties on the config are not copied.If you have other thoughts on how to do this then happy to change.