Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

expose span options #94

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Conversation

eli-jordan
Copy link
Contributor

@eli-jordan eli-jordan commented Jan 18, 2018

Fixes #93

The SpanOptions type is not exported from the module. This change simply adds an export to the index.ts file

@coveralls
Copy link

coveralls commented Jan 18, 2018

Coverage Status

Coverage remained the same at 88.78% when pulling c3dc39a on eli-jordan:expose-span-options into 1f32ae4 on opentracing:master.

@yurishkuro
Copy link
Member

Could you also fix the tests? E.g. here the import should from the index, not from ../tracer, to ensure that these imports are not missed.

https://github.com/opentracing/opentracing-javascript/blob/master/src/test/opentracing_api.ts#L5

@eli-jordan
Copy link
Contributor Author

@yurishkuro Done. I also updated mock_tracer._startSpan(...) to use the SpanOptions type

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage remained the same at 88.78% when pulling 04eb5cb on eli-jordan:expose-span-options into 1f32ae4 on opentracing:master.

.gitignore Outdated
@@ -5,3 +5,4 @@ typedoc/
dist/
lib/
.DS_Store
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can go into your $HOME/.gitignore_global

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip. I haven't use the global ignore file before. I reverted the change to the .gitignore

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage increased (+0.3%) to 88.525% when pulling b17eac9 on eli-jordan:expose-span-options into 1b32dfd on opentracing:master.

@yurishkuro yurishkuro merged commit caffd2d into opentracing:master Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants