This repository has been archived by the owner on May 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 108
expose span options #94
Merged
yurishkuro
merged 4 commits into
opentracing:master
from
eli-jordan:expose-span-options
Feb 26, 2018
Merged
expose span options #94
yurishkuro
merged 4 commits into
opentracing:master
from
eli-jordan:expose-span-options
Feb 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Jan 18, 2018
Could you also fix the tests? E.g. here the import should from the index, not from https://github.com/opentracing/opentracing-javascript/blob/master/src/test/opentracing_api.ts#L5 |
@yurishkuro Done. I also updated |
yurishkuro
approved these changes
Jan 19, 2018
.gitignore
Outdated
@@ -5,3 +5,4 @@ typedoc/ | |||
dist/ | |||
lib/ | |||
.DS_Store | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can go into your $HOME/.gitignore_global
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tip. I haven't use the global ignore file before. I reverted the change to the .gitignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
The
SpanOptions
type is not exported from the module. This change simply adds an export to theindex.ts
file