Address issues #13 and #41 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the suggestion from issue opentracing#41. If Tracer#start_active_span is given an optional block, it will return the block's return value, otherwise it will return the newly-created scope.
This commit addresses the suggestion in issue opentracing#13 and now allows Tracer#start_span to accept a block. When the block is given, it returns the block's return value, otherwise it returns the newly-created span.
|
🎉 Whoo! LGTM. We work closely with LightStep so once this gets published as a gem version I'll suggest they update their ruby gem as well. |
This was referenced Jan 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41 has been open for comment for quite some time, and all feedback has been in favor of the suggested changes. While discussing #41 there was interest in addressing #13 to provide symmetry between the
Tracer#start_spanandTracer#start_active_spanAPIs. This PR addresses both #13 and #41.Tracer#start_spannow accepts an optional block. When a block is given, it returns the block's return value, otherwise it returns the newly-created span. See #13.When
Tracer#start_active_spanis given an optional block, it will now return the block's return value, otherwise it returns the newly-created scope. This is a change from the previous behavior where it always returned the newly-created scope. See #41.