Added initial support to updated timetables for trips/[tripId]/stoptimes transit index call.

[vreixo]

This is the code being used for A Coruña server, and might be useful for other servers too, meanwhile all the class is not fully connected to timetableSnapshot.

With this, for API endpoint trips/[tripId]/stoptimes, realtime values are returned.

[hannesj]

This is already fixed in master, and should probably be closed.

[abyrd]

Thanks for checking that @hannesj

[sdjacobs]

@hannesj and @abyrd, could you take a look at this again? Based on my understanding and testing of the code, the API call /trips/{tripId}/stoptime currently returns scheduled stoptimes - though please correct me if I'm wrong here! This PR would enable that call to return stoptimes that are updated from realtime data.

[abyrd]

@sdjacobs and @barbeau thanks for drawing my attention to this. Looking at the source code, master does seem to only look at the scheduled timetable. @hannesj can you explain what you meant when you said this was fixed in master? Are you using a different endpoint to get the realtime information?

@vreixo sorry I closed this without further investigation, I thought we had confirmation that someone had already integrated the feature.

However, in this PR the scheduled timetable is simply swapped out for a real-time timetable. It seems to me that both should be included in the response.

[barbeau]

However, in this PR the scheduled timetable is simply swapped out for a real-time timetable. It seems to me that both should be included in the response.

+1 for this, ideally we would have both

[abyrd]

Actually I was wrong, the TripTimeShort constructor extracts both the scheduled and real-time arrivals and departures, as well as the delays. @vreixo's method is a good one for getting the right timetable. I'm merging this.

[abyrd]

Hi @vreixo, if you get a chance could you explain what you meant by "meanwhile all the class is not fully connected to timetableSnapshot"?

[hannesj]

@abyrd Sorry, I must have overseen something. I don't remember why I responded like that.

This patch has an issue if no StoptimeUpdater is configured, in that case req.rctx.timetableSnapshot is null and this will throw an NPE. Also this will always show the realtime departures of the current date, which I'm not sure is a wanted behaviour.

[hannesj]

A better way would be using TripPattern#getUpdatedTimetable to fetch the updated timetable.

[barbeau]

Thanks @abyrd!

[abyrd]

@hannesj thanks for the feedback. This will indeed always show the current date, but since this call has no date parameter this seems like the obvious default. And thanks for pointing out the null check in getUpdatedTimetable. It is important that this work for the vast majority of OTP deployments that do not have any real-time data. I will make that change.

[abyrd]

So in the end I didn't use TripPattern#getUpdatedTimetable because that expects a ServiceDay instead of a ServiceDate. I just added a null check. @hannesj and @barbeau please look at / test this out and let me know if there are any remaining problems.

[barbeau]

Thanks @abyrd! @sdjacobs Could you give this a shot with the OBA Android app? Latest commits @abyrd references are in master branch here.