fix(api): Add WALK to driving/TNC queries but not biking

Author: David Emory

lib/actions/api.js

@@ -8,6 +8,7 @@ if (typeof (fetch) === 'undefined') require('isomorphic-fetch')
 import { queryIsValid } from '../util/state'
 import queryParams from '../util/query-params'
 import { updateOtpUrlParams } from '../util/query'
+import { hasCar } from '../util/itinerary'
 
 // Generic API actions
 
@@ -123,8 +124,8 @@ function constructRoutingQuery (otpState, ignoreRealtimeUpdates) {
     }
   }
 
-  // hack to add walking to driving, TNC trips, bicycling
-  if (!params.mode.includes('WALK')) {
+  // hack to add walking to driving/TNC trips
+  if (hasCar(params.mode)) {
     params.mode += ',WALK'
   }
 

lib/util/itinerary.js

@@ -21,11 +21,17 @@ export function isTransit (mode) {
  * @return {boolean} whether any of the modes are transit modes
  */
 export function hasTransit (modesStr) {
-  let result = false
-  modesStr.split(',').forEach(mode => {
-    if (isTransit(mode)) result = true
-  })
-  return result
+  modesStr.split(',').forEach(mode => { if (isTransit(mode)) return true })
+  return false
+}
+
+/**
+ * @param  {string}  modesStr a comma-separated list of OTP modes
+ * @return {boolean} whether any of the modes are car-based modes
+ */
+export function hasCar (modesStr) {
+  modesStr.split(',').forEach(mode => { if (isCar(mode)) return true })
+  return false
 }
 
 export function isWalk (mode) {