-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/topo subgrouping #266
Conversation
UCC WG July 21st:
|
33dc7bd
to
b6eec0d
Compare
32 nodes, ppn 32 (max 1024 ranks)
this is ucc_team creation breakdown in usec. There is still 1 allgather that takes most of the time (i also discuss it in #274 how we should eliminate it). Again the cost of team_topo_init and actual subgroups creation (pure local math operations w/o communication) is nothing.
Final note, keep in mind that "topo" structs and sbgps are allocated only when TL/CL requires them. For this evaluation i specifically forced those flows (although cl/basic + tl/ucp does not ask for topo). |
@manjugv @bureddy @Sergei-Lebedev i added perf numbers and fixed minor linter issues. plz review. |
1a19e30
to
182276d
Compare
2871eea
to
9bd48e5
Compare
src/core/ucc_sbgp.c
Outdated
int _tmp = (_x); \ | ||
(_x) = (_y); \ | ||
(_y) = _tmp; \ | ||
} while (0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to math.h?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
9bd48e5
to
991884c
Compare
991884c
to
029af89
Compare
* CORE: basic topo/subgrouping * TEST: sbgp tests
What
Adds basic subgrouping functionality to UCC. Ranks participating in a team can now be partitioned into groups (1) belonging to same node, (2) socket, (3) nodeleaders, etc.
Why ?
These groupings are used to build hierarchical collective schedules
How ?