Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --with-docs-only to --with-only-docs #294

Closed
wants to merge 5 commits into from

Conversation

AndersonKao
Copy link

What

fixing --with-docs-only to --with-only-docs

Why ?

Because I encounter this error while trying to build the docs.
configure: error: --with-only-docs was requested, but doxygen was not found
Here is my running command

./autogen.sh
 ./configure --prefix=/tmp/ucc --with-docs-only

And it becomes good after switch to --with-only-docs

@mellanox-github
Copy link

Can one of the admins verify this patch?

@Sergei-Lebedev
Copy link
Contributor

@TunchinKao thanks for the PR. I think you indeed found a bug, but the fix is not correct.
When you configure with "--with-docs-only" option you need to have doxygen installed. So error message "configure: error: --with-only-docs was requested, but doxygen was not found" is almost good, except it should be "configure: error: --with-docs-only was requested, but doxygen was not found".
Correct fix will be to change error message in configure script

[AC_MSG_ERROR([--with-only-docs was requested, but doxygen was not found])])

@AndersonKao
Copy link
Author

@Sergei-Lebedev Thanks for your comment, I just found my logic mistake. XD. I will close this one and create a new correct PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants