EC/CUDA: fix build with 12.2 and older arch #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bureddy
approved these changes
Sep 25, 2023
manjugv
approved these changes
Sep 25, 2023
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
half datatype binary operators are not supported by cuda arch below 5.3 hence UCC does it in 3 steps: convert half to float, do float operation, convert float back to half. Since CUDA 12.2 this was added as part of standard distribution which breaks compilation. This PR adds relevant fix for it