BUILD: added support for amdclang-based build (#899) (v1.3.x) #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com> (cherry picked from commit 1bfa3f3)
|
Can one of the admins verify this patch? |
nileshnegi
changed the title
nileshnegi
changed the title
Sergei-Lebedev
approved these changes
Jan 31, 2024
|
@Sergei-Lebedev @manjugv really sorry, our internal CI has unearthed an issue with the pr on a platform over night. We will probably have to amend it by another patch. We are working on it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nileshnegi Nilesh.Negi@amd.com
(cherry picked from commit 1bfa3f3)
What
Adding support for clang-based build with ROCm 6.0 and above
Why ?
AMD plans to switch from hipcc to clang as its default compiler for ROCm 6.0 and above.