Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadcrumb] Should our default anatomy include hidden list elements? #201

Open
chrisdholt opened this issue Oct 18, 2020 · 1 comment
Open
Labels
breadcrumb Any issue related to the breadcrumb component needs-champion This means that this issue needs someone to champion the solution forward stale

Comments

@chrisdholt
Copy link
Collaborator

Carrying my comment on the default proposed anatomy including list items as aria-hidden for something which seems to always be presentational only.

If the expectation is that a separator (or divider) slotted in as part of a list item is presentational only - therefore, always hidden, why make that the rule? It seems more intuitive to expect that we have a presentational recommendation with this as "allowable". Either way, I think we need a caveat that this can be handled a couple of ways (per @assuncaocharles's comment elsewhere in the spec).

It may just be myself, but I prefer verbosity on some of these things when we're providing a recommendation or "blessed" implementation.

@gregwhitworth gregwhitworth added the breadcrumb Any issue related to the breadcrumb component label Oct 19, 2020
@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 19, 2022
@mfreed7 mfreed7 added the needs-champion This means that this issue needs someone to champion the solution forward label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breadcrumb Any issue related to the breadcrumb component needs-champion This means that this issue needs someone to champion the solution forward stale
Projects
None yet
Development

No branches or pull requests

3 participants