feat(breadcrumb): add proposal

[assuncaocharles]

Adds Breadcrumb proposal

[assuncaocharles]

Hey @gregwhitworth

Have a look in this one when you can :)

[gregwhitworth]

@assuncaocharles I left a comment, ultimately I think it'd be cool to jump on a call for 30 minutes to work through some of these and get on the same page. To help land this. DM me on Twitter or email me so we can set this up.

[gregwhitworth]

Not sure how to represent like that in the anatomy. How it would be in the anatomy @una @gregwhitworth @chrisdholt ?

Technically the ::marker psuedo element is there for any li so we don't have to represent it. Although I get your reasoning for including it, what you have represented is fine with me although I'd prefer for it to not be side by side, or to make the psuedo element size to min-content. This makes the psuedo element appear much larger than that of item.

Also, the box itself of the marker comes before the item itself so it should be placed first.

[assuncaocharles]

Not sure how to represent like that in the anatomy. How it would be in the anatomy @una @gregwhitworth @chrisdholt ?

Technically the ::marker psuedo element is there for any li so we don't have to represent it. Although I get your reasoning for including it, what you have represented is fine with me although I'd prefer for it to not be side by side, or to make the psuedo element size to min-content. This makes the psuedo element appear much larger than that of item.

Also, the box itself of the marker comes before the item itself so it should be placed first.

@gregwhitworth In the image bellow ::marker is inside li as a pseudo-element would be.

[kant2002]

I notice that SAP Fiory provide some interesting concept for Breadcrumb.

I think this concept valuable for large projects, where breadcrumbs can be rather large in length

My understanding that this cannot be represented in current breadcrumb proposal. So question, should such advanced cases like this be part of Open UI?

[kant2002]

The Carbon Design System from IBM suggest different way for collapse of breadcrumbs

from there

[una]

It seems like there are open issues around a breadcrumb dropdown functionality. That seems like a (very useful) combination of components, rather than default base functionality. Would you all be okay with merging this PR and taking that discussion into a new issue?

[una]

@assuncaocharles did you add ::marker? I don't see it in the PR. Would love to merge it in

[assuncaocharles]

@una i did not, I'm not sure how to express that in the anatomy as I said before

[gregwhitworth]

@assuncaocharles this one looks correct to me, granted it wouldn't have the divider part on it: #165 (comment)

Finally, and this is what I'd like @chrisdholt and @una to weigh in on - do we really need to add ::marker as it is already a standardized pseudo element of a list-item?

[chrisdholt]

@assuncaocharles this one looks correct to me, granted it wouldn't have the divider part on it: #165 (comment)

Finally, and this is what I'd like @chrisdholt and @una to weigh in on - do we really need to add ::marker as it is already a standardized pseudo element of a list-item?

You can create the same UIA representation using ARIA and while I know that's not completely ideal, it is valid and ::marker wouldn't work there. I don't know that we need to make that the rule though, more saying that both can be accurate representations - this really comes down to nuance in my mind.

[gregwhitworth]

@assuncaocharles can you do a final pass looking at @chrisdholt commit recommendations so that we can do an initial landing of this PR

[andrico1234]

Hi folks (@gregwhitworth @una @chrisdholt @assuncaocharles )

I've updated this PR to include Chris' suggested changes. Are you happy for me to merge this in?

[scottaohara]

things to update / considerations to make

[andrico1234]

Thanks for taking the time to leave comments @scottaohara , I've merged in the typo corrections and other suggested changes.

As for the rest of the comments, I'm not sure how to best approach them. I'll be happy to make notes within the proposal about these unresolved questions, e.g. the correct markup for the spacer, to get this (20 month old 😱) PR merged in. Whoever decides to champion this proposal in the future can resolve the comments.

I believe this was addressed in a previous commit a while back. Happy to make additional changes if they're still outstanding