-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[focusgroup] i18n: should arrow key navigation follow text direction? #522
Comments
@travisleithead let me know if this is ready for agenda. I think a summary of the options would be of value. I've also labeled it so that the i18n team can see it and weigh in. |
There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label. |
As a Bidi user, I am used to the Notepad behavior where left-arrow is Prev and right-arrow is Next where the paragraph direction is LTR and vice-versa where the paragraph direction is RTL.. Note that other apps may behave differently. |
There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label. |
Issue #870 recommends adding 'inline' and 'block' for logical movement (which should be the recommended approach IMO), where 'horizontal' and 'vertical' are for physical movement. This matches the behavior of the CSS |
Current plan:
|
The Open UI Community Group just discussed The full IRC log of that discussion<gregwhitworth> Travis: a couple of key points does right arrow key change with text direction or not<gregwhitworth> Travis: there is plenty of evidence in 522 and 859 should follow the direction of the content <masonf> q+ <gregwhitworth> Travis: so if you're in RTL then the left arrow key would move you "forward" and we shoudl adopt that <gregwhitworth> Travis: there is also an issue with horizontal and vertical as a value to limit which values are possible <gregwhitworth> Travis: already a PR to introduce logical properties and would of course just go with the flow of the content <luke> q+ <gregwhitworth> ack masonf <brecht_dr> q+ <gregwhitworth> masonf: just one clarification, I think you should follow the direction of the text. Is the focusgroup elements direction or the element you're on? <gregwhitworth> masonf: you can end up in a scenario where you bounce back and forth <gregwhitworth> ack luke <gregwhitworth> luke: one thing I question with this, should we just make logical be the other physical values? <gregwhitworth> luke: I think the absolute physical values are almost always the wrong thing to do <gregwhitworth> luke: they exist in CSS due to history <gregwhitworth> luke: maybe that's wrong but I can't think of a reason to use physical properties <gregwhitworth> luke: I agree with the focusgroup being where the writing mode direction is derived <gregwhitworth> Travis: sounds good, thank you <gregwhitworth> ack brecht_dr <gregwhitworth> brecht_dr: first off thank you and +1 to it being the focusgroup container <gregwhitworth> brecht_dr: it should probably be logical only <gregwhitworth> brecht_dr: there are older websites and platforms that only use hacks primarily for floats and change direction in other stylesheet you can end up in a danger zone? <gregwhitworth> brecht_dr: I'm unsure but wanted to raise it |
* Clarify i18n arrow key directionality mapping * Adds a use case directionality of arrow keys following content. * Slightly more precise definition of the directionality values of `inline` and `block`. * Removes definition of `horizontal` and `vertical` values which are not recommended values as these are not content-direction aware. * Replaces usages of `horizontal` and `vertical` with corresponding `inline` and `block` and updates associated prose. Fixes: #522
I18N has added this issue to our agenda for our 2024-03-21 call. Keyboard cursor behavior is known to be complicated in a bidi context and we want to ensure that your text resolves this. None of us, to my knowledge, has reviewed #1011 yet. |
Re-opening based on @aphillips desire for additional review |
There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label. |
This issue has been transferred from MicrosoftEdge/MSEdgeExplainers#514
@fvsch opened this issue on 2021-09-09
@bkardell commented on 2021-09-16
@travisleithead commented on 2021-09-28
@travisleithead commented on 2021-09-29
@tabatkins commented 2021-10-21
The text was updated successfully, but these errors were encountered: