-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[selectmenu] Method to apply styles only in open state #547
Comments
Correct, there is currently no way to style the selectmenu based on its open state (somewhat related too, there is no way to style it based on the position of the popup, which could be useful). This is a known limitation that I'm sure must be tracked somewhere, although I can't find an issue on this repo. @dandclark may know. |
Ah yes, style based on position of popup would be great too, a common use case (and in video above) would be when the popup visually has an arrow that points to its trigger. |
I think it would make sense to have an Styling based on the position of the popup would be a bit more complicated and the exact shape of it will depend on what comes out of the anchor positioning proposal. I would expect that for many use cases where developer cares about listbox positioning, they would be replacing the default listbox and swapping in their own, e.g. to add the arrow pointing back to the button. In this case they could query the popup position as it's exposed by anchor pos, without |
For reference, CSSWG resolved to add |
I forgot to set up the css-meeting-bot for this issue in the last minutes, so just to circle back: Last week we got to this resolution:
(as captured in the first part of the minutes) |
The Open UI Community Group just discussed The full IRC log of that discussion<gregwhitworth> Topic: [selectmenu] Method to apply styles only in open state<gregwhitworth> github: https://github.com//issues/547 <JonathanNeal> dandclark: should css have a pseudo class to see whether the selectmenu is open or not. there will be one that can apply generally to things, and we will use that. |
From a prior meeting:
|
This was discussed in openui#547
I am implementing :open and :closed in chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 |
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593}
…losed, a=testonly Automatic update from web-platform-tests selectmenu: Add support for :open and :closed This was discussed here: openui/open-ui#547 Bug: 1121840 Change-Id: I44de1f38ce4c754b1046c2eea3837955ab026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370850 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122593} -- wpt-commits: 2f5784f5fe10d878efccabb2463ad9458b86e562 wpt-pr: 39200
In a selectmenu-like pattern in our product, the button part has a background color while the select is open. I may be overlooking something obvious, but it looks to me like there isn't a way in the current
<selectmenu>
to apply styles to a button for an opened selectmenu.select.mov
Video alt: text editor with selector for content semantics like heading level 1, heading level 2; while the selector is open, the button has a blue background, otherwise it is white
I wonder if there could be a way to allow for this, maybe through a pseudo class?
(Maybe related to #311)
The text was updated successfully, but these errors were encountered: