Research: popup and similar top-layer UI #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanierichards
requested review from
gregwhitworth,
levithomason and
una
as code owners
gregwhitworth
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is effectively a rework of #205, which presented various types of top-layer UI together for discussion on whether these are in scope for "popup". This PR is a little bit more specific about what constitutes a popup, and which top-layer elements are in/out of scope and why.
This PR moves a couple concepts to their own research pages, which are very lightweight by design so as to not over-bloat this PR. We should add more details to this research in follow-up PRs.
This PR
Popup
Adds further research on popup, including behaviors and subclasses/subtypes. Those include:
Similar components
These have their own research pages now: