Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phonetics for 夫 #523

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix phonetics for 夫 #523

merged 1 commit into from
Sep 18, 2024

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Sep 7, 2024

The concise dictionary has the following phrase with ㄈㄨ˙.

大夫
工夫
功夫
下功夫
下工夫
頂上功夫
箱底功夫
水磨工夫
一盞茶工夫

https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%A4%AB&page=1
https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%A4%AB&page=2
https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%A4%AB&page=3

Also provide both ㄉㄚˋ ㄈㄨ and ㄉㄞˋ ㄈㄨ for 大夫 for fault tolerance.

https://dict.revised.moe.edu.tw/dictView.jsp?ID=40677&q=1&word=%E5%A4%A7%E5%A4%AB#order1

Copy link
Member

@tianjianjiang tianjianjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also provide both ㄉㄚˋ ㄈㄨ and ㄉㄞˋ ㄈㄨ for 大夫 for fault tolerance.

Although I'm personally ok with this kind of deviation (even though their meanings are quite different) since there are already wrongly assign syllables, but I recommend not adding /ㄉㄚˋ ㄈㄨ˙/ because it generally doesn't exist.

@xatier
Copy link
Contributor Author

xatier commented Sep 17, 2024

@tianjianjiang I attempted to cover all combinations for fault tolerance, removed ㄉㄚˋ ㄈㄨ˙ as requested.

@tianjianjiang
Copy link
Member

@tianjianjiang I attempted to cover all combinations for fault tolerance, removed ㄉㄚˋ ㄈㄨ˙ as requested.

@xatier Thank you for that! 🙏

BTW, my preference:

  • If it's possible to pronounce in that way, it's ok to add it even if it's not in good references.
  • If it's highly unlikely to pronounce in that way, not adding it may keep the syllables informative, e.g., those are actual usages.
    • Even if something like /ㄉㄚˋ ㄈㄨ˙/ isn't added, if /ㄈㄨ˙/ is actually of a free morpheme, it will be added as a monosyllable (of 夫 for example), and then "combination" will naturally occur. It may cover reasonable "fault tolerance."

@lukhnos lukhnos merged commit 74cbd3f into openvanilla:master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants