Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix GMM test #1696

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

📝 Description

  • The test_gmm.py is flaky as the randomly generated datapoints might end up near the wrong cluster.
    In the first image, the colours show the labels expected by the test but from the figure you can see that the clusters are close to the wrong cluster.
image

The solution is probably too conservative but the new clusters are now separated by a large margin.

image

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jan 31, 2024
@samet-akcay samet-akcay merged commit b5ceacf into openvinotoolkit:main Jan 31, 2024
6 of 7 checks passed
adrianboguszewski pushed a commit to adrianboguszewski/anomalib that referenced this pull request Feb 9, 2024
* Separate data

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* limit torch version

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants