Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accuracy control quantization #2070

Merged
merged 12 commits into from
Jun 6, 2024

Conversation

adrianboguszewski
Copy link
Contributor

πŸ“ Description

  • Accuracy control quantization in NNCF while exporting to OpenVINO

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@adrianboguszewski adrianboguszewski marked this pull request as ready for review May 20, 2024 16:57
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few comments

src/anomalib/engine/engine.py Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, and for your patience waiting for this to be reviewed. I've got few minor comments.

src/anomalib/deploy/export.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two super minor comment, then we could merge.

src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
src/anomalib/models/components/base/export_mixin.py Outdated Show resolved Hide resolved
@samet-akcay samet-akcay enabled auto-merge (squash) June 3, 2024 14:04
auto-merge was automatically disabled June 3, 2024 14:06

Head branch was pushed to by a user without write access

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

src/anomalib/engine/engine.py Show resolved Hide resolved
@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) June 6, 2024 10:29
@ashwinvaidya17 ashwinvaidya17 merged commit 41d8cf9 into openvinotoolkit:main Jun 6, 2024
5 of 7 checks passed
@adrianboguszewski adrianboguszewski deleted the ov-nncf-acq branch June 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants