Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨Remove device postfix #2233

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Aug 5, 2024

📝 Description

Testing method

tox.ini

[tox]
isolated_build = True
skip_missing_interpreters = true
envlist =
    pre-commit
    pre-merge-py{38,39,310}
    snyk-scan
+     install-py{310, 311}

[testenv]
passenv = ftp_proxy
    HTTP_PROXY
    HTTPS_PROXY
    CUDA_VISIBLE_DEVICES

[testenv:pre-commit]
basepython = py310
deps =
    pre-commit
commands = pre-commit run --all-files

+ [testenv:install-py{310,311}]
+ commands = 
+     pip install -e .
+     anomalib install --option full -v
+
+     pytest tests/test_setup.py
    
[testenv:pre-merge-py{38,39,310}]

tests/test_setup.py

import torch
def test_setup():
    assert(torch.cuda.is_available())

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@samet-akcay samet-akcay merged commit 1a041d1 into openvinotoolkit:main Aug 5, 2024
5 checks passed
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (d1f824a) to head (a147871).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
+ Coverage   80.82%   80.89%   +0.07%     
==========================================
  Files         248      248              
  Lines       10876    10859      -17     
==========================================
- Hits         8790     8784       -6     
+ Misses       2086     2075      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants