Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Git for Open Data Hub / OpenShift Data Science #266

Closed
ryanloney opened this issue Sep 23, 2021 · 2 comments
Closed

Jupyter Git for Open Data Hub / OpenShift Data Science #266

ryanloney opened this issue Sep 23, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ryanloney
Copy link
Contributor

We have been asked to include jupyterlab-git in the Dockerfile for the notebooks. This is commonly used in ODH/ODS. I don't know if we need it for all users, but can we add it to the Dockerfile? Is it as simple as adding jupyterlab-git to requirements?

https://github.com/jupyterlab/jupyterlab-git

Since we are using JupyterLab 3.X, it looks like we do not need to run "jupyter lab build"

Let me know what you think. This can wait a few weeks, but want to make sure it is technically feasible.

@ryanloney ryanloney added the enhancement New feature or request label Sep 23, 2021
@helena-intel
Copy link
Contributor

It is no problem to add it, we already have it in dev-requirements.txt. But it adds an element to the UI, and the extension had issues for me recently (the diff would not show correctly). I don't recommend adding it for everyone.

@helena-intel
Copy link
Contributor

Fixed in #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants