probably wrong order of openvpnserv2.exe and TAP installation

[chipitsine]

https://github.com/OpenVPN/openvpn-build/blob/master/windows-nsis/openvpn.nsi#L283

openvpnserv2.exe depends on "tap0901", however, TAP driver is installed after openvpnserv2.exe

[selvanair]

The service is started after TAP is installed so should be fine. IIRC, this has been discussed in the past and service start was moved to where it is now.

[chipitsine]

does sc.exe allow creation of service dependent on nonexistent service/driver ?

[selvanair]

Yes, "sc config servicename depend= some-nonsense" will work as long as
servicename is valid. The dependency gets checked only when the service is started.

[chipitsine]

earlier TAP required a reboot after install. is it the reason to install it on the last stage?

[selvanair]

The current order works so why bother. Anyway the user can opt to not install TAP (say already installed and do not want to re-install) so it should work in either order. Of course starting the service will fail if TAP is not found and the logs will show it. We do make sure that the service is started at the end of the installation, which, I think, is the correct way to do it, independent of dependency on TAP etc.

…

On Sat, Jan 7, 2017 at 1:37 PM, Ilya Shipitsin ***@***.***> wrote: earlier TAP required a reboot after install. is it the reason to install it on the last stage? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzAT-YScD2PcbO3g-qbxjuw7Cwzp-GPks5rP9t8gaJpZM4LdfDA> .

[chipitsine]

the order is ok. I apologies for the issue.