Skip to content

Commit c9e10ac

Browse files
david-marchandigsilya
authored andcommitted
netdev-dpdk: Drop coverage counter for vhost IRQs.
The vhost library now provides finegrained statistics for guest notifications: - notifications for buffer reclaim by the guest, - notifications for buffer availability to the guest, Example before this patch: $ ovs-appctl coverage/show | grep vhost_notification vhost_notification 0.0/sec 0.000/sec 2.0283/sec total: 7302 $ ovs-vsctl get interface vhost4 statistics | sed -e 's#[{}]##g' -e 's#, #\n#g' | grep guest_notifications rx_q0_guest_notifications=66 tx_q0_guest_notifications=7236 Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Signed-off-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
1 parent 3b29286 commit c9e10ac

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

lib/netdev-dpdk.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ VLOG_DEFINE_THIS_MODULE(netdev_dpdk);
7878
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
7979

8080
COVERAGE_DEFINE(vhost_tx_contention);
81-
COVERAGE_DEFINE(vhost_notification);
8281

8382
static char *vhost_sock_dir = NULL; /* Location of vhost-user sockets */
8483
static bool vhost_iommu_enabled = false; /* Status of vHost IOMMU support */
@@ -188,7 +187,6 @@ static int new_device(int vid);
188187
static void destroy_device(int vid);
189188
static int vring_state_changed(int vid, uint16_t queue_id, int enable);
190189
static void destroy_connection(int vid);
191-
static void vhost_guest_notified(int vid);
192190

193191
static const struct rte_vhost_device_ops virtio_net_device_ops =
194192
{
@@ -198,7 +196,6 @@ static const struct rte_vhost_device_ops virtio_net_device_ops =
198196
.features_changed = NULL,
199197
.new_connection = NULL,
200198
.destroy_connection = destroy_connection,
201-
.guest_notified = vhost_guest_notified,
202199
};
203200

204201
/* Custom software stats for dpdk ports */
@@ -4350,12 +4347,6 @@ destroy_connection(int vid)
43504347
}
43514348
}
43524349

4353-
static
4354-
void vhost_guest_notified(int vid OVS_UNUSED)
4355-
{
4356-
COVERAGE_INC(vhost_notification);
4357-
}
4358-
43594350
/*
43604351
* Retrieve the DPDK virtio device ID (vid) associated with a vhostuser
43614352
* or vhostuserclient netdev.

0 commit comments

Comments
 (0)