Add authenticator2john.py to extract authenticator app passwords. Closes #4893

[marksilinio]

see #4893 for details

[marksilinio]

python2/python3 compatible:

$ python2.7 ./authenticator2john.py ~/.authenticator/authenticator.data 
authenticator.data:$authenticator$0$7a6a5a4a00000001000400007a6a5a4a$24b6b919b5685dc9c6ac4e6e4fba8026
$ python3.9 ./authenticator2john.py ~/.authenticator/authenticator.data 
authenticator.data:$authenticator$0$7a6a5a4a00000001000400007a6a5a4a$24b6b919b5685dc9c6ac4e6e4fba8026

[magnumripper]

Looks fine to me, if @solardiz is fine with the license blurb

[marksilinio]

Are there any preferred licenses?

[magnumripper]

Our most preferred license is the cut-down BSD license, but I believe GPLv2 is fine too.

[solardiz]

@marksilinio magnum is correct, our preferred is the same one you had used in apop2john.py - can you do the same here? GPLv2 is also fine if you insist, just let us know if so. Thanks!

[solardiz]

Do we want to merge this script now or only along with the corresponding JtR format?

We similarly had a PR with bestcryptve2john.py hanging around for months and only merged when we also had the format. The reason for not merging the script right away was not to cause confusion by something not really supported yet.

[marksilinio]

@marksilinio magnum is correct, our preferred is the same one you had used in apop2john.py - can you do the same here? GPLv2 is also fine if you insist, just let us know if so. Thanks!

Done

[magnumripper]

Do we want to merge this script now or only along with the corresponding JtR format?

We similarly had a PR with bestcryptve2john.py hanging around for months and only merged when we also had the format. The reason for not merging the script right away was not to cause confusion by something not really supported yet.

I'll write the formats soon so let's wait a little. I might even be able to push the formats commits to this same PR

[solardiz]

I'll write the formats soon so let's wait a little.

OK.

I might even be able to push the formats commits to this same PR

I think it's better to have two PRs, but plan on merging them on the same day.

[claudioandre-br]

This PR now has Conflicting files that must be resolved before merging. I think it is bad to wait so long for a merge.

We must merge it. Maybe move the 2john* file to the "unused folder " for a while.

[solardiz]

Merge branch 'bleeding-jumbo' into authenticator2john

Let's not be doing things like that. Let's be rebasing instead.

[claudioandre-br]

Merge branch 'bleeding-jumbo' into authenticator2john

Let's not be doing things like that. Let's be rebasing instead.

I used the Github GUI to fix the source code conflict.

• Or the author amend
• Or an administrator handles
• Or we use the squash option to merge