External modes test and minor optimization #5480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests almost all external modes on
make check
, which we run on CI.This also adds proper compile-time handling of negative integer constants, which previously emitted the unary
-
instruction. Unfortunately, the code for this is a hack. It was cleaner not to handle this case specially.My additional test case (not included here) for this optimization is:
This has a mix of
-
in different meanings, which the compiler has to distinguish properly. The expected output isa
.