Rename X509Certificate to X509Cert and add partial support for iOS + tests #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests This rename helps avoid confusion on the JVM when using javaX509Certificate to get a java.security.cert.X509Certificate instance for the certificate. Also implement partial support for X509Cert on iOS - still need to implement code for getting the EC curve from the certificate which includes parsing ASN.1. Test: ./gradlew check Signed-off-by: David Zeuthen <zeuthen@google.com>
sorotokin
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename helps avoid confusion on the JVM when using javaX509Certificate to get a java.security.cert.X509Certificate instance for the certificate.
Also implement partial support for X509Cert on iOS - still need to implement code for getting the EC curve from the certificate which includes parsing ASN.1.
Test: ./gradlew check