Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indy-sdk-react-native as declared dependency instead of vendoring #156

Closed
cvarjao opened this issue Dec 1, 2021 · 5 comments
Closed

indy-sdk-react-native as declared dependency instead of vendoring #156

cvarjao opened this issue Dec 1, 2021 · 5 comments

Comments

@cvarjao
Copy link
Contributor

cvarjao commented Dec 1, 2021

As per Twelve-Factor App methodology, switch to "Explicitly declare and isolate dependencies" to "declares all dependencies, completely and exactly, via a dependency declaration manifest"

@TimoGlastra
Copy link
Contributor

I'm not 100% sure what you mean by this issue. Could you elaborate a bit @cvarjao?

@cvarjao
Copy link
Contributor Author

cvarjao commented Dec 1, 2021

It is about getting indy-sdk-react-native packaged/published (maybe using CocoaPods?), instead of copying the files to ios/Pods/Frameworks/Indy.framework

@TimoGlastra
Copy link
Contributor

Ah makes sense. That would be really great! Are you going to package the indy binaries with the package, or going to install them with some post install script?

@cvarjao
Copy link
Contributor Author

cvarjao commented Dec 1, 2021

I just create the issue so I can get somebody else looking into it :D I am not an iOS developer. But, I think it might require some work on the Indy repository side to do the publishing. Hopefully, we can leverage CocoaPods dependency management to take care of the fetching/installing as opposed to the hacky custom download/extract post install script I've introduced for Android. But similar along the lines where the dependency is declared and somewhat installed.

@cvarjao cvarjao changed the title indy-sdk-react-native as dependency instead of vendoring indy-sdk-react-native as declared dependency instead of vendoring Dec 1, 2021
@jleach
Copy link
Contributor

jleach commented Feb 13, 2023

Going to close this one. The work @TimoGlastra is doing to move AFJ towards ASKAR will make this issue irrelevant. The's already created several tickets to track this work. See #617 for more information.

@jleach jleach closed this as completed Feb 13, 2023
jcdrouin21 pushed a commit to MCN-ING/aries-mobile-agent-react-native that referenced this issue May 16, 2023
…ove-contact-test-dev

Trun off retry attempts on failure for BCW tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants