chore(push-notifications)!: update to afj 0.4.0 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
fix: do not hoist @aries-framework or @hyperledger
Signed-off-by: Moriarty <moritz@animo.id>
…tification-040 Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Moriarty <moritz@animo.id>
morrieinmaas
force-pushed
the
feat/push-notification-040
branch
from
ccadce8
to
0dd56cb
Compare
Signed-off-by: Moriarty <moritz@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 24 24
Lines 1241 1241
Branches 287 270 -17
=======================================
Hits 1077 1077
Misses 164 164 |
|
@TimoGlastra @blu3beri i've changed the integration test to use 16 and 18 node - is that desired? |
janrtvld
reviewed
May 10, 2023
packages/push-notifications/src/PushNotificationsModuleConfig.ts
Outdated
Show resolved
Hide resolved
janrtvld
reviewed
May 10, 2023
Yeah that's fine. |
Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Mo <10432473+morrieinmaas@users.noreply.github.com>
|
@blu3beri how do i get rid of the pending expected integration tests? |
janrtvld
reviewed
May 17, 2023
I think @TimoGlastra can set new CI pipelines to be required and remove these. I can not do that. |
Ah thanks for clarifying |
added 2 commits
May 17, 2023 10:15
Signed-off-by: Moriarty <moritz@animo.id>
* remove module config as its unused Signed-off-by: Moriarty <moritz@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
changed the title
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
approved these changes
Jun 23, 2023
Co-authored-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.