Development & software operations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@yssavchuk Please, don't include Node.js in Docker images. Also use latest Ruby – 2.5. |
|
@yssavchuk Please, allow to customize RAILS_ENV in Docker image. Always set RAILS_ENV. |
|
@yssavchuk You can check peatio repo on how to solve these issues. |
|
@yivo okay thanks |
ysv
changed the title
yivo
suggested changes
Jan 9, 2018
config/database.yml
Outdated
| database: barong_production | ||
| username: barong | ||
| password: <%= ENV['BARONG_DATABASE_PASSWORD'] %> | ||
| database: <%= ENV['DATABASE_NAME'] %> |
There was a problem hiding this comment.
@yssavchuk Please, use ENV.fetch if you require value.
| name: {{ template "fullname" . }} | ||
| key: cookiesSecretKey | ||
| {{- if .Values.db.password }} | ||
| - name: DATABASE_PASS |
There was a problem hiding this comment.
@yssavchuk It is much better to use DATABASE_PASS!
|
@yssavchuk Please, rebase. |
yivo
changed the title
yivo
changed the title
yivo
force-pushed
the
kite
branch
2 times, most recently
from
6af0438
to
c83bb72
Compare
yivo
changed the title
yivo
added
peer:approved
PR: WIP
and removed
PR: WIP
PR: changes needed
peer:approved
labels
yivo
approved these changes
Jan 10, 2018
ysv
force-pushed
the
kite
branch
2 times, most recently
from
136d1be
to
bd7e3c9
Compare
…pipeline, Helm & other stuff.
mod
requested changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.