add cli prompt support for cirque home #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingchik
force-pushed
the
feature/cirque_cli_support
branch
from
0a0cdc1
to
b149a09
Compare
|
./cirque/common/cirqueprompt.py:25:1: E302 expected 2 blank lines, found 1 |
mingchik
force-pushed
the
feature/cirque_cli_support
branch
from
b149a09
to
15bbb3e
Compare
cirque/common/cirqueprompt.py
Outdated
| parser.add_argument('--base_image', type=str) | ||
| parser.add_argument('--capability', type=str) | ||
| parser.add_argument('--rcp_mode', action='store_true', default=False) | ||
| parser.add_argument('--weave_config_file', type=str) |
There was a problem hiding this comment.
create_device is generic CLI command, which should not have weave_config_file
|
|
||
|
|
||
| class CirquePrompt(cmd.Cmd): | ||
| prompt = 'cirque> ' |
There was a problem hiding this comment.
please add help function
please add list homes
please add list devices
please add send_cmd which can send command to particular device.
There was a problem hiding this comment.
is there any chances that developer would create multiple homes locally?
help function, ack!
home_devces = list devices
run_exec = send_cmd
gjc13
reviewed
Jul 13, 2020
cirque/common/cirqueprompt.py
Outdated
| 'type': args.type, | ||
| 'base_image': args.base_image if args.base_image else None, | ||
| 'capability': capabilities, | ||
| 'rcp_mode': True if args.base_image else False, |
There was a problem hiding this comment.
Suggested change
| 'rcp_mode': True if args.base_image else False, | |
| 'rcp_mode': True if args.rcp_mode else False, |
mingchik
force-pushed
the
feature/cirque_cli_support
branch
4 times, most recently
from
fe66d12
to
464be50
Compare
gjc13
approved these changes
Jul 15, 2020
mingchik
force-pushed
the
feature/cirque_cli_support
branch
4 times, most recently
from
06e8446
to
dd93a4a
Compare
Usage: cirque> create_home cirque> create_device --type wifi_ap cirque> create_device --type generic_node_image --capability WiFi,Thread,Interactive --rcp_mode cirque> device_state --device_id <device_id> cirque> close_device --device_id <device_id> cirque> homes (list all the homes) cirque> home_devices (list all the devices) cirque> run_exec --device_id <device_id> --command <command> (run command inside docker container) cirque> destroy_home cirque> version cirque> history cirque> exit Help: cirque> help Documented commands (use 'help -v' for verbose/'help <topic>' for details): =========================================================================== close_device create_home device_state help home_devices run_exec create_device destroy_home exit history homes version
mingchik
force-pushed
the
feature/cirque_cli_support
branch
from
dd93a4a
to
77d19f8
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
cirque> create_home
cirque> create_device --type wifi_ap
cirque> create_device --type generic_node_image --capability WiFi,Thread,Interactive --rcp_mode
cirque> home_devices (list all the devices)
cirque> device_state --device_id <device_id>
cirque> run_exec --device_id <device_id> --command (run
command inside docker container)
cirque> close_device --device_id <device_id>
cirque> destroy_home