Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

artifact support to get both lwip and linux-auto logs to gcs #182

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

jenniexie
Copy link
Contributor

@jenniexie jenniexie commented Mar 19, 2019

I've got artifacts work with gcs using travis-ci interface, PR is:
#182

I have tested on my repo, here is the link of test logs upload example on gcs:
https://pantheon.corp.google.com/storage/browser/openweave/happy-test-log/164/?project=openweave-test-project&authuser=0&organizationId=433637338589

I've enabled it for all branches, so it should upload logs automatically to gcs from PR branch as well.

Hope this effort will help debugging the test flakiness on travis-ci.

Please let me know if you have any questions.

Note: Content in .travis.yml got shift to front a little bit, that is done by command "travis setup gcs" during travis-ci/gcs setup, more info is in this link:
https://docs.travis-ci.com/user/deployment/gcs/

@jenniexie jenniexie force-pushed the master branch 3 times, most recently from e8fafb1 to a99741d Compare March 20, 2019 00:26
@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         326      326           
  Lines       55972    55972           
=======================================
  Hits        30353    30353           
  Misses      25619    25619

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034eb42...9f678f3. Read the comment docs.

@gerickson
Copy link
Contributor

There are a lot of gratuitous white space diffs here. Can you unwind those so we are just getting the material changes. If you need to do a squash and force push after cleaning those up, please do (let me know if you need help with those).

Copy link
Contributor

@gerickson gerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, there's a lot of duplicated, and undocumented, copy-and-paste code in .travis/script.sh. Please identify and propose opportunities for refactoring that code into a common subroutine or common code with more documentation.

.travis.yml Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis/script.sh Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@jenniexie
Copy link
Contributor Author

Overall, there's a lot of duplicated, and undocumented, copy-and-paste code in .travis/script.sh. Please identify and propose opportunities for refactoring that code into a common subroutine or common code with more documentation.

I am working on this one, I like this comment. I will move the common code into a bash function.

.travis/script.sh Outdated Show resolved Hide resolved
@jenniexie
Copy link
Contributor Author

ping RS @robszewczyk, could you help with this PR? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants