feat: add windows support. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我想参与到这个项目来,请问我能帮助测试window这个平台的PR吗 |
andycall
force-pushed
the
feat/windows_support
branch
2 times, most recently
from
b53b621
to
ce7805b
Compare
|
@bai-3 欢迎参与 WebF 贡献，请留下你的联系方式以便我能联系到你 |
1 task
andycall
force-pushed
the
feat/windows_support
branch
17 times, most recently
from
69a6cc3
to
1e785a4
Compare
andycall
force-pushed
the
feat/windows_support
branch
from
fa1d6d5
to
ef4af06
Compare
andycall
force-pushed
the
feat/windows_support
branch
2 times, most recently
from
fb9db6c
to
e79547d
Compare
andycall
force-pushed
the
feat/windows_support
branch
from
742622e
to
d091460
Compare
github-actions
bot
force-pushed
the
feat/windows_support
branch
from
d091460
to
3b43fa1
Compare
github-actions
bot
force-pushed
the
feat/windows_support
branch
from
3b43fa1
to
7c4c69d
Compare
devjiangzhou
approved these changes
May 23, 2023
|
LGTM |
ErosZy
approved these changes
May 23, 2023
XGHeaven
reviewed
May 23, 2023
Comment on lines
+517
to
+558
| if (${CMAKE_BUILD_TYPE} STREQUAL "Release" OR ${CMAKE_BUILD_TYPE} STREQUAL "RelWithDebInfo") | ||
| target_compile_options(webf PRIVATE -fno-exceptions -fvisibility=hidden -fno-rtti) | ||
| else () | ||
| ### remove dynamic_cast and exceptions | ||
| target_compile_options(webf PRIVATE -fno-exceptions -fno-rtti) | ||
| endif () |
| @@ -580,7 +618,7 @@ if (${CMAKE_SYSTEM_NAME} MATCHES "iOS") | |||
| PUBLIC_HEADER ${WEBF_PUBLIC_HEADERS} | |||
| ) | |||
|
|
|||
| # If quickjs is static, there will be no quickjs.framework any more. | |||
| # If quickjs is static, there will be no quickjs.framework any more.1 | |||
looseyi
pushed a commit
that referenced
this pull request
May 29, 2024
[1.84.0][NEZ][FIX] fix: layout and color error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running WebF in windows platform.
CoTaskMemAllocandCoTaskMemFreeallocators instead ofmallocandfreefrom kernel32.dll, as in the dart ffi package >= 2.0.0, Dart has migrate to these allocator instead of kernel32.dll. These shared structs areSharedNativeStringandDartReadblestruct.stdatomic.hand pthread-win32 library to make quickjs works on windows.mimallocto v2.1.1 to fix the MSVC compile issue.