Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Self Poly Inline Cache for quickjs #227

Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat: add Self Poly Inline Cache for quickjs #227

merged 2 commits into from
Jan 17, 2023

Conversation

ErosZy
Copy link
Member

@ErosZy ErosZy commented Jan 17, 2023

What kind of change does this PR introduce?
Add self poly inline cache to quickjs

Does this PR introduce a breaking change?
No.

Why submit this PR?

  • improve the performance of object get / set operations;

Does the test262 pass?
Yes.

Benchmark

  • GCC 8.3.0
  • AMD Ryzen5 3600
  • Linux 5.15.77-amd64-desktop
> hyperfine --warmup 1 --runs 3 --show-output "./bin/qjs ./bin/index.js"
master feat/ic
Richards 752 888 +18.0%
Crypto 618 713 +15.3%
RayTrace 807 833 +3.2%
NavierStokes 1497 1319 -11.8%
DeltaBlue 744 845 +13.5%
Score (version 7) 841 890 +5.5%

@ErosZy ErosZy requested review from tiye and andycall January 17, 2023 07:27
@ErosZy ErosZy changed the title feat: add Self Poly Inline Cache to quickjs feat: add Self Poly Inline Cache for quickjs Jan 17, 2023
tiye
tiye approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tiye tiye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@ErosZy ErosZy merged commit f7185a4 into main Jan 17, 2023
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@tiye tiye tiye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErosZy @tiye @andycall