Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix dom content loaded event trigger condition. #274

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix: fix dom content loaded event trigger condition. #274

merged 3 commits into from
Mar 30, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Mar 7, 2023 

The DOMContentLoaded event fires when the HTML document has been completely parsed, and all deferred scripts (<script defer src="…"> and <script type="module">) have downloaded and executed. It doesn't wait for other things like images, subframes, and async scripts to finish loading.

@andycall andycall force-pushed the fix/dom_content_loaded_event branch from 99a08b4 to 254976e Compare March 11, 2023 04:33
@andycall andycall enabled auto-merge March 27, 2023 10:16
@andycall andycall added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit b2e0d02 Mar 30, 2023
andycall added a commit that referenced this pull request Apr 13, 2023
@andycall
fix: fix dom content loaded event trigger condition. (#274)
bc3dfa5 
* fix: fix dom content loaded event trigger condition

* fix: fix DOMContentLoaded blocked by stylesheet requests.

* fix: dispatch domcontentloaded event in current frame.
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XGHeaven XGHeaven XGHeaven approved these changes

@devjiangzhou devjiangzhou devjiangzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andycall @devjiangzhou @XGHeaven