Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flex): fix flex:1 failed when style minHeigh/minWidth #28

Merged
merged 11 commits into from
Aug 23, 2022
Merged

fix(flex): fix flex:1 failed when style minHeigh/minWidth #28

merged 11 commits into from
Aug 23, 2022

Conversation

pba-cra
Copy link
Contributor

@pba-cra pba-cra commented Aug 17, 2022

fix:#27

@pba-cra pba-cra requested a review from andycall August 17, 2022 08:26
@andycall
Copy link
Member

test spec missing?

andycall
andycall requested changes Aug 21, 2022
View reviewed changes
Copy link
Member

@andycall andycall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test spec required. @pba-cra

andycall
andycall requested changes Aug 21, 2022
View reviewed changes
webf/lib/src/css/values/length.dart Outdated Show resolved Hide resolved
@andycall andycall merged commit 37d1536 into main Aug 23, 2022
@pba-cra
Copy link
Contributor Author

pba-cra commented Aug 25, 2022

fix #32

@pba-cra pba-cra mentioned this pull request Aug 25, 2022
Closed
1 task
@liuzitong123a liuzitong123a mentioned this pull request Oct 21, 2022
Closed
1 task
@devjiangzhou devjiangzhou mentioned this pull request Nov 20, 2022
Closed
1 task
@NoahJinnn NoahJinnn mentioned this pull request May 12, 2023
Open
1 task
@andycall andycall deleted the feature/fix_flex_failed branch June 7, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall andycall approved these changes

@devjiangzhou devjiangzhou devjiangzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pba-cra @andycall @devjiangzhou