Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure renderObject had been layout before read view module properties. #333

Merged
merged 3 commits into from
May 14, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented May 1, 2023

Fix the view module properties(like offsetLeft) got 0 when the renderObject didn't layout.

This bug was introduced by #326

@yifei8
Copy link
Member

yifei8 commented May 8, 2023

An unknown error will be triggered in the business, which needs to be further defined. It is not recommended to merge

@andycall
Copy link
Member Author

andycall commented May 8, 2023

An unknown error will be triggered in the business, which needs to be further defined. It is not recommended to merge

Fixed at 3d0e653

@andycall andycall added this pull request to the merge queue May 14, 2023
Merged via the queue into main with commit 6c5ef70 May 14, 2023
@andycall andycall deleted the fix/view_module_properties branch May 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants